fix(core): Ensure JIT components also use OnPush by default. - #69898
Open
JeanMeche wants to merge 1 commit into
Open
fix(core): Ensure JIT components also use OnPush by default.#69898JeanMeche wants to merge 1 commit into
OnPush by default.#69898JeanMeche wants to merge 1 commit into
Conversation
JeanMeche
force-pushed
the
onpush-jit
branch
3 times, most recently
from
July 22, 2026 23:38
19ab2fb to
11a22d2
Compare
JeanMeche
marked this pull request as ready for review
July 26, 2026 16:14
14 tasks
Unfortunate oversight when landing angular#67687, it was missed here that OnPush should also be the default for JIT compiled component.
Member
Author
|
Marking as breaking change because of the test impacts. Note: This shouldn't be an issue when running the tests with Vitest, as it uses AOT by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunate oversight when landing #67687, it was missed here that OnPush should also be the default for JIT compiled component.
This behavior also affects tests that run in JIT mode (which is the default with Karma)