Repository navigation
Conversation
…rivate/testing Move the duplicated `promiseWithResolvers` utility function from submit.spec.ts, debounce.spec.ts, form_field.spec.ts, interop.spec.ts, compat.spec.ts, and signal_form_control.spec.ts into `packages/private/testing/src/utils.ts` and replace all local definitions with an import from `@angular/private/testing`. Fix call sites that resolve with a non-void value to use an explicit type parameter (e.g. `promiseWithResolvers<boolean>()`) to match the shared function's `T = void` default.
kbrilla
reviewed
Jul 9, 2026
| * Replace with `Promise.withResolvers()` once it's available. | ||
| * NET September 2026 | ||
| * | ||
| * See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/withResolvers. |
Contributor
There was a problem hiding this comment.
Promise.withResolvers() is already available in node version used by this repo, as it's available since node v22. So we could use native one.
Contributor
|
Thanks for making this change. Since |
Contributor
Author
|
Can we proceed with this, since we're not moving forward with #69739? |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the duplicated
promiseWithResolversutility function from submit.spec.ts, debounce.spec.ts, form_field.spec.ts, interop.spec.ts, compat.spec.ts, and signal_form_control.spec.ts intopackages/private/testing/src/utils.tsand replace all local definitions with an import from@angular/private/testing.Fix call sites that resolve with a non-void value to use an explicit type parameter (e.g.
promiseWithResolvers<boolean>()) to match the shared function'sT = voiddefault.