Sitelet https://github.com/angular/angular/pull/64393
Skip to content

refactoring(migrations): unit test signal migration adjustment - #64393

Closed
aparzi wants to merge 1 commit into
angular:mainfrom
aparzi:refactoring-testing-signal-migration
Closed

refactoring(migrations): unit test signal migration adjustment#64393
aparzi wants to merge 1 commit into
angular:mainfrom
aparzi:refactoring-testing-signal-migration

Conversation

@aparzi

@aparzi aparzi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

Move unit test from spec file to golden test

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Move unit test for signal migration from spec file to golden test

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove
pullapprove Bot requested a review from mmalerba October 13, 2025 20:28
JeanMeche
JeanMeche approved these changes Oct 13, 2025
View reviewed changes

@JeanMeche JeanMeche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the cleanup !

@JeanMeche
JeanMeche removed the request for review from mmalerba October 13, 2025 20:29
@JeanMeche JeanMeche added the target: patch This PR is targeted for the next patch release label Oct 13, 2025
@JeanMeche

JeanMeche commented Oct 13, 2025

Copy link
Copy Markdown
Member

The commit message should be a refactoring(migrations): ...

@aparzi
aparzi force-pushed the refactoring-testing-signal-migration branch from fc10685 to 0e5c564 Compare October 13, 2025 20:47
@aparzi aparzi changed the title fix(refactoring): unit test signal migration adjustment refactoring(schematics): unit test signal migration adjustment Oct 13, 2025
@aparzi
aparzi requested a review from JeanMeche October 13, 2025 20:48
@aparzi

aparzi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

The commit message should be a refactoring(migrations): ...

Commit message updated

@JeanMeche

JeanMeche commented Oct 13, 2025

Copy link
Copy Markdown
Member

migrations not schematics ;)

@aparzi aparzi changed the title refactoring(schematics): unit test signal migration adjustment refactoring(migrations): unit test signal migration adjustment Oct 13, 2025
@aparzi

aparzi commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

migrations not schematics ;)

sorry 馃う

@aparzi
aparzi force-pushed the refactoring-testing-signal-migration branch from 0e5c564 to 6e79da0 Compare October 13, 2025 20:57
@angular-robot angular-robot Bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Oct 13, 2025
@ngbot ngbot Bot added this to the Backlog milestone Oct 13, 2025
@aparzi
aparzi force-pushed the refactoring-testing-signal-migration branch from 6e79da0 to 6e0bf78 Compare October 13, 2025 21:13
@aparzi
refactor(migrations): unit test signal migration adjustment
f1c7417 
Move unit test from spec file to golden test
@aparzi
aparzi force-pushed the refactoring-testing-signal-migration branch from 6e0bf78 to f1c7417 Compare October 13, 2025 21:52
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2025
@AndrewKushnir

AndrewKushnir commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

AndrewKushnir pushed a commit that referenced this pull request Oct 15, 2025
@aparzi @AndrewKushnir
refactor(migrations): unit test signal migration adjustment (#64393)
0bf157c 
Move unit test from spec file to golden test

PR Close #64393
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 15, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@aparzi @JeanMeche @AndrewKushnir