Conversation
… pattern The type alias allows for this pattern to be more easily used in other areas of the compiler code. The current usages of this pattern have been updated to use the type alias.
The resource loader uses TypeScript's module resolution system to determine at which locations it needs to look for a resource file. A marker string is used to force the module resolution to fail, such that all failed lookup locations can then be considered for actual resource resolution. Any filesystem requests targeting files/directories that contain the marker are known not to exist, so no filesystem request needs to be done at all.
JoostK
force-pushed
the
ngtsc/perf/resource-adapter
branch
from
November 10, 2020 13:24
44de12a to
24e3b63
Compare
petebacondarwin
approved these changes
Nov 10, 2020
JoostK
marked this pull request as ready for review
November 10, 2020 13:50
Contributor
atscott
pushed a commit
that referenced
this pull request
Nov 12, 2020
…#39604) The resource loader uses TypeScript's module resolution system to determine at which locations it needs to look for a resource file. A marker string is used to force the module resolution to fail, such that all failed lookup locations can then be considered for actual resource resolution. Any filesystem requests targeting files/directories that contain the marker are known not to exist, so no filesystem request needs to be done at all. PR Close #39604
atscott
pushed a commit
that referenced
this pull request
Nov 12, 2020
…#39604) The resource loader uses TypeScript's module resolution system to determine at which locations it needs to look for a resource file. A marker string is used to force the module resolution to fail, such that all failed lookup locations can then be considered for actual resource resolution. Any filesystem requests targeting files/directories that contain the marker are known not to exist, so no filesystem request needs to be done at all. PR Close #39604
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.