fix(http): queue jsonp <script> tag onLoad event handler in microtask - #39512
Closed
sebastianhaeni wants to merge 1 commit into
Closed
sebastianhaeni wants to merge 1 commit into
sebastianhaeni wants to merge 1 commit into
Conversation
JiaLiPassion
suggested changes
Oct 31, 2020
JiaLiPassion
left a comment
Contributor
There was a problem hiding this comment.
just like I commented in #39496, I think we can use a promise.then here to delay the execution.
Also could you add a test case to verify this fix?
Contributor
Author
|
@JiaLiPassion thank you for your comments! |
JiaLiPassion
suggested changes
Oct 31, 2020
JiaLiPassion
reviewed
Nov 2, 2020
Before this change, when trying to load a JSONP script that calls the JSONP callback inside a microtask, it will fail in Internet Explorer 11 and EdgeHTML. This commit changes the onLoad cleanup to be queued after the loaded endpoint executed any potential microtask itself. This ensures that the aforementioned browsers will first evaluate the loaded script calling the JSONP callback and only then run the cleanup inside onLoad. Fixes #39496
JiaLiPassion
approved these changes
Nov 2, 2020
JiaLiPassion
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the research and the fix!
mhevery
approved these changes
Nov 16, 2020
mhevery
approved these changes
Nov 16, 2020
mhevery
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: global-approvers
Contributor
atscott
pushed a commit
that referenced
this pull request
Nov 17, 2020
…#39512) Before this change, when trying to load a JSONP script that calls the JSONP callback inside a microtask, it will fail in Internet Explorer 11 and EdgeHTML. This commit changes the onLoad cleanup to be queued after the loaded endpoint executed any potential microtask itself. This ensures that the aforementioned browsers will first evaluate the loaded script calling the JSONP callback and only then run the cleanup inside onLoad. Fixes #39496 PR Close #39512
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39496
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #39496
Before this change, when trying to load a JSONP script that calls the JSONP callback inside a setTimeout function, it will fail in Internet Explorer 11 and EdgeHTML.
What is the new behavior?
This commit changes the event handler on the script tag to be queued with setTimeout. This ensures that the aforementioned browsers will first evaluate the loaded script calling the JSONP callback and only then run the load handler which does the tear down of the callback function and script tag.
Does this PR introduce a breaking change?