Conversation
crisbeto
commented
Oct 10, 2020
Member
Author
There was a problem hiding this comment.
This change isn't required for the migration, but it makes it so that vscode can autocomplete the Jasmine functions in tests.
crisbeto
force-pushed
the
wait-for-async-migration
branch
from
October 10, 2020 11:03
7c97834 to
81ff023
Compare
crisbeto
marked this pull request as ready for review
October 10, 2020 11:37
josephperrott
approved these changes
Oct 12, 2020
josephperrott
left a comment
Member
There was a problem hiding this comment.
LGTM
Just the one comment to take a look at.
Adds a migration that finds all imports and calls to the deprecated `async` function from `@angular/core/testing` and replaces them with `waitForAsync`. These changes also move a bit of code out of the `Renderer2` migration so that it can be reused.
crisbeto
force-pushed
the
wait-for-async-migration
branch
from
October 12, 2020 16:07
81ff023 to
cedf76a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a migration that finds all imports and calls to the deprecated
asyncfunction from@angular/core/testingand replaces them withwaitForAsync.These changes also move a bit of code out of the
Renderer2migration so that it can be reused.