Sitelet https://github.com/angular/angular/pull/38882
Skip to content

feat: remove ViewEncapsulation.Native - #38882

Closed
crisbeto wants to merge 2 commits into
angular:masterfrom
crisbeto:native-view-encapsulation
Closed

feat: remove ViewEncapsulation.Native#38882
crisbeto wants to merge 2 commits into
angular:masterfrom
crisbeto:native-view-encapsulation

Conversation

@crisbeto

@crisbeto crisbeto commented Sep 17, 2020

Copy link
Copy Markdown
Member

See the individual commits for more context, but the high-level overview is:

  1. Adds an automated migration that will replace any usages of ViewEncapsulation.Native with ViewEncapsulation.ShadowDom.
  2. Removes the Native value from ViewEncapsulation and replaces any usages in tests and docs with ShadowDom.

@crisbeto
crisbeto force-pushed the native-view-encapsulation branch 7 times, most recently from 6d3f47c to e8183bc Compare September 17, 2020 19:14
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Sep 17, 2020
@ngbot ngbot Bot added this to the needsTriage milestone Sep 17, 2020
@crisbeto
crisbeto marked this pull request as ready for review September 17, 2020 19:39
@crisbeto crisbeto added cross-cutting: types target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Sep 17, 2020
IgorMinar
IgorMinar approved these changes Sep 17, 2020
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions. thanks!

Comment thread packages/core/schematics/migrations/native-view-encapsulation/index.ts Outdated
Comment thread packages/core/schematics/migrations/native-view-encapsulation/README.md Outdated
@crisbeto
crisbeto force-pushed the native-view-encapsulation branch from e8183bc to 08ac35f Compare September 18, 2020 17:32
AndrewKushnir
AndrewKushnir reviewed Sep 18, 2020
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, just left 1 minor comment 👍

Comment thread packages/compiler-cli/test/ngtsc/fake_core/index.ts Outdated
devversion
devversion approved these changes Sep 22, 2020
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the migration code.

@crisbeto
crisbeto force-pushed the native-view-encapsulation branch from 08ac35f to b9efc1f Compare September 25, 2020 09:35
@crisbeto

crisbeto commented Sep 25, 2020

Copy link
Copy Markdown
Member Author

I've addressed the latest set of feedback and added a temporary fallback for code that is still using the Native encapsulation.

@crisbeto
crisbeto force-pushed the native-view-encapsulation branch 2 times, most recently from 14c800f to 7eda534 Compare September 25, 2020 10:01
AndrewKushnir
AndrewKushnir reviewed Sep 28, 2020
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making updates @crisbeto, I just left a couple comments.

Comment thread packages/core/src/view/util.ts Outdated
Comment thread packages/platform-browser/src/dom/dom_renderer.ts Outdated
@crisbeto
crisbeto force-pushed the native-view-encapsulation branch from 7eda534 to 6e91023 Compare September 29, 2020 06:26
@pullapprove
pullapprove Bot requested review from IgorMinar and jelbourn October 6, 2020 18:22
@crisbeto crisbeto added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 6, 2020
@pullapprove
pullapprove Bot requested a review from AndrewKushnir October 6, 2020 19:04
AndrewKushnir
AndrewKushnir approved these changes Oct 6, 2020
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from atscott October 6, 2020 19:14
atscott
atscott approved these changes Oct 6, 2020
View reviewed changes

@atscott atscott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from petebacondarwin October 6, 2020 19:46
petebacondarwin
petebacondarwin reviewed Oct 6, 2020
View reviewed changes

@petebacondarwin petebacondarwin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some drive-by comments that you can ignore.

Comment thread goldens/size-tracking/integration-payloads.json Outdated
Comment thread packages/core/src/render3/node_manipulation.ts Outdated
Comment thread packages/platform-browser/testing/src/matchers.ts Outdated
petebacondarwin
petebacondarwin approved these changes Oct 6, 2020
View reviewed changes

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove
pullapprove Bot requested a review from petebacondarwin October 6, 2020 20:15
petebacondarwin
petebacondarwin approved these changes Oct 6, 2020
View reviewed changes

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@pullapprove
pullapprove Bot requested a review from AndrewKushnir October 6, 2020 20:26
AndrewKushnir
AndrewKushnir approved these changes Oct 6, 2020
View reviewed changes

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release and removed action: presubmit The PR is in need of a google3 presubmit target: patch This PR is targeted for the next patch release labels Oct 6, 2020
@josephperrott
josephperrott force-pushed the native-view-encapsulation branch from b2fc07d to d0a0037 Compare October 6, 2020 20:57
@crisbeto
feat(core): add automated migration to replace ViewEncapsulation.Native
adbfde7 
Adds an automated migration that replaces any usages of the deprecated
`ViewEncapsulation.Native` with `ViewEncapsulation.ShadowDom`.
@crisbeto
feat(core): remove ViewEncapsulation.Native
3c47eb2 
Removes `ViewEncapsulation.Native` which has been deprecated for several major versions.

BREAKING CHANGES:
* `ViewEncapsulation.Native` has been removed. Use `ViewEncapsulation.ShadowDom` instead. Existing
usages will be updated automatically by `ng update`.
@crisbeto
crisbeto force-pushed the native-view-encapsulation branch from d0a0037 to 3c47eb2 Compare October 8, 2020 14:59
@atscott atscott closed this in 0e733f3 Oct 8, 2020
atscott pushed a commit that referenced this pull request Oct 8, 2020
@crisbeto @atscott
feat(core): remove ViewEncapsulation.Native (#38882)
4a1c12c 
Removes `ViewEncapsulation.Native` which has been deprecated for several major versions.

BREAKING CHANGES:
* `ViewEncapsulation.Native` has been removed. Use `ViewEncapsulation.ShadowDom` instead. Existing
usages will be updated automatically by `ng update`.

PR Close #38882
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 8, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes
@alxhub alxhub alxhub approved these changes
@devversion devversion devversion approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes
+2 more reviewers
@petebacondarwin petebacondarwin petebacondarwin approved these changes
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime breaking changes cla: yes cross-cutting: types target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

8 participants

@crisbeto @AndrewKushnir @petebacondarwin @IgorMinar @atscott @alxhub @devversion @googlebot