Sitelet https://github.com/angular/angular/pull/38698
Skip to content

feat(router): Add relativeLinkResolution migration to update defaul… - #38698

Closed
atscott wants to merge 5 commits into
angular:masterfrom
atscott:relativeLinkResolutionMigration
Closed

feat(router): Add relativeLinkResolution migration to update defaul…#38698
atscott wants to merge 5 commits into
angular:masterfrom
atscott:relativeLinkResolutionMigration

Conversation

@atscott

@atscott atscott commented Sep 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

…t value

The default value for relativeLinkResolution is changing from 'legacy' to 'corrected'.
This migration updates RouterModule configurations that use the default value to
now specifically use 'legacy' to prevent breakages when updating.

See also #25609 and #37355

@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: router target: major This PR is targeted for the next major release area: migrations Issues related to `ng update`/`ng generate` migrations labels Sep 3, 2020
@atscott
atscott requested a review from crisbeto September 3, 2020 16:08
@ngbot ngbot Bot modified the milestone: needsTriage Sep 3, 2020
@pullapprove
pullapprove Bot requested a review from gkalpak September 3, 2020 16:09
@atscott
atscott force-pushed the relativeLinkResolutionMigration branch from f8b8902 to 072c96b Compare September 3, 2020 16:19
crisbeto
crisbeto reviewed Sep 3, 2020
View reviewed changes
Comment thread packages/core/schematics/migrations/relative-link-resolution/collector.ts Outdated
Comment thread packages/core/schematics/migrations/relative-link-resolution/collector.ts Outdated
Comment thread packages/core/schematics/migrations/relative-link-resolution/transform.ts Outdated
Comment thread packages/core/schematics/test/relative_link_resolution_spec.ts Outdated
crisbeto
crisbeto approved these changes Sep 9, 2020
View reviewed changes

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion approved these changes Sep 9, 2020
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few comments

Comment thread packages/core/schematics/migrations.json Outdated
Comment thread packages/core/schematics/migrations/relative-link-resolution/collector.ts Outdated
Comment thread packages/core/schematics/migrations/relative-link-resolution/transform.ts Outdated
@devversion devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 9, 2020
@atscott
atscott force-pushed the relativeLinkResolutionMigration branch from 4f80028 to a053063 Compare September 10, 2020 16:35
@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 10, 2020
@atscott

atscott commented Sep 10, 2020

Copy link
Copy Markdown
Contributor Author

@crisbeto @devversion PTAL - I added the g3 migration to this PR. I was going to add it to a follow-up but I think it makes more sense to include it all in one

@atscott
atscott force-pushed the relativeLinkResolutionMigration branch from cd74693 to 98bb98f Compare September 10, 2020 20:33
devversion
devversion approved these changes Sep 11, 2020
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done!

Comment thread packages/core/schematics/migrations/relative-link-resolution/transform.ts Outdated
@atscott
atscott force-pushed the relativeLinkResolutionMigration branch 2 times, most recently from 2ebbef1 to be79ced Compare September 14, 2020 16:48
atscott and others added 4 commits September 17, 2020 11:13
@atscott
feat(router): Add relativeLinkResolution migration to update defaul…
41d16e4 
…t value

The default value for `relativeLinkResolution` is changing from 'legacy' to 'corrected'.
This migration updates `RouterModule` configurations that use the default value to
now specifically use 'legacy' to prevent breakages when updating.
@atscott
fixup! feat(router): Add relativeLinkResolution migration to update…
022efb6 
… default value
@atscott
fixup! feat(router): Add relativeLinkResolution migration to update…
a34b411 
… default value
@atscott
fixup! feat(router): Add relativeLinkResolution migration to update…
2861749 
… default value
@atscott
atscott force-pushed the relativeLinkResolutionMigration branch from be79ced to 2861749 Compare September 17, 2020 18:15
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2020
@alxhub alxhub closed this in 15ea811 Sep 23, 2020
@atscott atscott mentioned this pull request Oct 10, 2020
Closed
4 of 14 tasks
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 24, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes
@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations area: router cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@atscott @crisbeto @devversion @googlebot