Repository navigation
fix(router): lazy loaded empty root path loads with auxiliary outlet - #32526
asvishnyakov wants to merge 10 commits into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
|
This PR isn't really fixing the problem, so I'm closing it. If I'll find correct solution I'll reopen it. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is correct implementation and replacement of #25483
Given the following route configuration:
With this configuration, using the outlet as an entry point to the application, the root module will not load properly and results in the following error:
TypeError: Cannot read property 'routes' of undefined at getChildConfig (router.js:3041)The
_loadedConfigproperty of the route remainsundefinedas theexpandSegmentAgainstRoute()isn't executed.This issue is only present if the root has a lazy loaded module, works fine with a component or even with a lazy loaded module if the root path is not empty.
Issue Number: #12842
What is the new behavior?
Does this PR introduce a breaking change?
Other information