Sitelet https://github.com/amit-writes-code/cli/pull/45
Skip to content

[pull] main from temporalio:main - #45

Merged
pull[bot] merged 1 commit into
amit-writes-code:mainfrom
temporalio:main
Sep 10, 2026
Merged

pull[bot] merged 1 commit into
amit-writes-code:mainfrom
temporalio:main

Conversation

@pull

@pull pull Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

## What changed?

Resurrects the `--reset-heartbeats` flag removed from `activity reset` 
in PR #1092, as a new flag `--clear-heartbeat-details`. It controls the 
existing `reset_heartbeat` field on both the single-activity request and
the batch operation, and the proto field is unchanged as
`ResetHeartbeat`.

💥 #1092 also hardcoded `reset_heartbeat: true` on the batch path, 
so batch resets via `--query` always cleared the heartbeat details,
while the
single-activity did not, as the default is to not clear the details.
This change
in behavior was triggered in that PR, and now this new PR reverts the 
default behavior to what was before that PR. Since this change is to
revert an
earlier breaking change, and both PRs happened before the release, 
it should be fine.
Both paths are now controlled by this flag.

Rename `#reset-heartbeats` anchor to `#clear-heartbeat-details` 
for consistency. 

Tests cover the flag on both single activity and batch paths.

## Checklist

**Stability**
- [x] Breaking changes are marked with 💥 in the PR title and release
notes

**Design**
- [x] New flags are named after the API concept, not the implementation
mechanism (good: `--search-attribute`, bad: `--index-field`)
- [x] New flags don't duplicate an existing flag that serves the same
purpose
- [x] New flags do not have short aliases without strong justification

**Help text** (see style guide at the top of `commands.yaml`)
- [x] All flags shown in help text and examples are implemented and
functional

**Tests**
- [x] Added functional test(s) (`SharedServerSuite`)
@pull pull Bot locked and limited conversation to collaborators Sep 10, 2026
@pull pull Bot added the ⤵️ pull label Sep 10, 2026
@pull
pull Bot merged commit d47e1e6 into amit-writes-code:main Sep 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant