[pull] main from temporalio:main - #45
Merged
Merged
Conversation
## What changed? Resurrects the `--reset-heartbeats` flag removed from `activity reset` in PR #1092, as a new flag `--clear-heartbeat-details`. It controls the existing `reset_heartbeat` field on both the single-activity request and the batch operation, and the proto field is unchanged as `ResetHeartbeat`. 💥 #1092 also hardcoded `reset_heartbeat: true` on the batch path, so batch resets via `--query` always cleared the heartbeat details, while the single-activity did not, as the default is to not clear the details. This change in behavior was triggered in that PR, and now this new PR reverts the default behavior to what was before that PR. Since this change is to revert an earlier breaking change, and both PRs happened before the release, it should be fine. Both paths are now controlled by this flag. Rename `#reset-heartbeats` anchor to `#clear-heartbeat-details` for consistency. Tests cover the flag on both single activity and batch paths. ## Checklist **Stability** - [x] Breaking changes are marked with 💥 in the PR title and release notes **Design** - [x] New flags are named after the API concept, not the implementation mechanism (good: `--search-attribute`, bad: `--index-field`) - [x] New flags don't duplicate an existing flag that serves the same purpose - [x] New flags do not have short aliases without strong justification **Help text** (see style guide at the top of `commands.yaml`) - [x] All flags shown in help text and examples are implemented and functional **Tests** - [x] Added functional test(s) (`SharedServerSuite`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )