feat: support solc prereleases - #176
Merged
Merged
Conversation
grandizzy
marked this pull request as ready for review
November 19, 2025 05:45
grandizzy
requested review from
DaniPopes,
mattsse and
zerosnacks
as code owners
November 19, 2025 05:45
3 tasks
onbjerg
pushed a commit
to foundry-rs/compilers
that referenced
this pull request
Nov 19, 2025
- preserve version, including prerelease if any, and pass to svm-rs - needed in `find_svm_installed_version` to identify local binary and avoid installing it on each run - svm-rs logic to deal with looking up and installing prereleases in alloy-rs/svm-rs#176
mattsse
approved these changes
Nov 19, 2025
Comment on lines
+132
to
+133
| pub path: Option<String>, | ||
| pub prerelease: Option<String>, |
Comment on lines
+84
to
+88
| let matched_prelease = !v.pre.is_empty() | ||
| && build_info.version == Version::new(v.major, v.minor, v.patch) | ||
| && build_info.prerelease.as_deref() == Some(v.pre.as_str()); | ||
|
|
||
| matched_release || matched_prelease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "builds": [ ... { "path": "solc-linux-amd64-v0.8.30+commit.73712a01", "version": "0.8.30", "build": "commit.73712a01", "longVersion": "0.8.30+commit.73712a01", ... }, { "path": "solc-linux-amd64-v0.8.31-pre.1+commit.b59566f6", "version": "0.8.31", "prerelease": "pre.1", "build": "commit.b59566f6", "longVersion": "0.8.31-pre.1+commit.b59566f6", ... } ], "releases": { "0.8.30": "solc-linux-amd64-v0.8.30+commit.73712a01", ... }, "latestRelease": "0.8.30" }{ "builds": [ ... { "version": "0.8.30", "sha256": "54f48274e5ec8a58b378f07c226fa1e25801526b6b0d16129f3a14a18efe72cd" }, { "version": "0.8.31-pre.1", "sha256": "70bd29bdc271654c58e2cbd62f2b55d2b97db49ed97f42775287f8c43e285bd5" } ], "releases": { ... "0.8.30": "solc-v0.8.30", "0.8.31-pre.1": "solc-v0.8.31-pre.1" } }