feat(contracts): add gas estimation layer example and use recommended layers across examples - #33
Closed
zerosnacks wants to merge 17 commits into
Closed
zerosnacks wants to merge 17 commits into
zerosnacks wants to merge 17 commits into
Conversation
…ploy_from_contract` and `deploy_from_artifact` examples
zerosnacks
commented
Mar 27, 2024
Comment on lines
+54
to
+57
| .map(|mut tx| { | ||
| tx.set_chain_id(anvil.chain_id()); | ||
| tx | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Expected as a method directly accessible on contract_builder
Contributor
Author
There was a problem hiding this comment.
The default case will likely be resolved by the new FillTxLayer proposal: alloy-rs/alloy#374 but generally still a good method to have direct access to I think.
zerosnacks
commented
Mar 27, 2024
| let contract_address = | ||
| contract_builder.gas(estimate).gas_price(base_fee).nonce(0).deploy().await?; | ||
| let contract_address = contract_builder | ||
| .from(alice) |
Contributor
Author
There was a problem hiding this comment.
Expected not to be required, should be implicit that alice is the from if set as signer
Contributor
Author
|
Now unblocked: alloy-rs/alloy#406 Will likely require a refactor and reconsideration of proposed changes |
1 of 2 tasks
Contributor
Author
|
Close in favor of #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Blocked by upstream changes to improve API in alloy-rs/alloy#406
Specifically around current handling of
fromfield, missingchain_idfield (handled in FillTxLayer) and ordering of layers.