fix: bump alloy to 0.15 - #199
Merged
Merged
Conversation
zerosnacks
marked this pull request as ready for review
May 9, 2025 08:41
2 tasks
zerosnacks
commented
May 9, 2025
| // Create a provider with both signers pointing to anvil | ||
| let rpc_url = anvil.endpoint_url(); | ||
| let provider = ProviderBuilder::new().wallet(wallet).on_http(rpc_url); | ||
| let provider = ProviderBuilder::new().wallet(wallet).connect_http(rpc_url); |
Contributor
Author
There was a problem hiding this comment.
Seeing a
Sent approval: 0x93426765c406ba149df94b52df30b415bc812b7d384dbcaafb9a389a4eec3555
Error: server returned an error response: error code 3: execution reverted, data: "0x"
Does not appear to be a regression as it also appears on main
Still worth looking into
Contributor
Author
There was a problem hiding this comment.
Adding to the ignore list in run.sh for now
Contributor
Author
There was a problem hiding this comment.
added follow-up ticket for it here: #218
mattsse
approved these changes
May 9, 2025
mattsse
approved these changes
May 12, 2025
Comment on lines
+23
to
+27
| reth-db = { git = "https://github.com/paradigmxyz/reth", package = "reth-db", rev = "55f4b0b" } | ||
| reth-provider = { git = "https://github.com/paradigmxyz/reth", package = "reth-provider", rev = "55f4b0b" } | ||
| reth-node-types = { git = "https://github.com/paradigmxyz/reth", package = "reth-node-types", rev = "55f4b0b" } | ||
| reth-chainspec = { git = "https://github.com/paradigmxyz/reth", package = "reth-chainspec", rev = "55f4b0b" } | ||
| reth-node-ethereum = { git = "https://github.com/paradigmxyz/reth", package = "reth-node-ethereum", rev = "55f4b0b" } |
Member
There was a problem hiding this comment.
we could also move this entirely to reth and just reference it here
Contributor
Author
|
lgtm! @yash-atreya |
zerosnacks
commented
May 12, 2025
| providers::{Provider, ProviderBuilder}, | ||
| rpc::types::TransactionRequest, | ||
| }; | ||
| use alloy_evm::{eth::EthEvmContext, EthEvm, Evm}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Updates:
Alloy to 0.15
Bump
foundry-fork-dbafter REVM compatibility (feat: bump revm to21.0.0and alloy to0.13.0foundry-rs/foundry-fork-db#44)~~Update examples to be compatible with new REVM~~
Added follow-up ticket here: #217
PR Checklist