feat: table support resize column width by igauch · Pull Request #533 · alauda/ui

igauch · 2023-12-15T08:48:33Z

close #541

changeset-bot · 2023-12-15T08:48:36Z

🦋 Changeset detected

Latest commit: 6b036ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@alauda/ui	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

JounQin

Need more discussion about the necessary of this feature.

fengtianze · 2023-12-15T09:49:24Z

demo异常

JounQin · 2024-01-04T04:05:05Z

不要总是用 amend + force push，每次 push 都要重新 review 完整的 PR？应该分 commit 更方便 review ，也能保留修改历史

JounQin · 2024-01-18T03:02:10Z

+  cleanup(): void {
+    if (this.styleSheet) {
+      const i = document.adoptedStyleSheets.indexOf(this.styleSheet);
+      document.adoptedStyleSheets.splice(i, 1);


这个提过，用 filter 吧，i 万一是 -1 怎么办？

JounQin · 2024-01-18T03:03:32Z

+      );
+    }
+    if (width.endsWith('px')) {
+      return parseInt(width.slice(0, -2));


Suggested change

return parseInt(width.slice(0, -2));

return Number.parseFloat(width.slice(0, -2));

怎么感觉被恢复成最开始的代码了？所有 review 后的变更都没了。。。

JounQin · 2024-01-18T03:03:48Z

+    if (width.endsWith('px')) {
+      return parseInt(width.slice(0, -2));
+    }
+    return parseInt(width);


Suggested change

return parseInt(width);

return Number.parseFloat(width);

JounQin · 2024-01-18T03:07:34Z

+        this.renderer2.setStyle(
+          markLine,
+          'left',
+          offset - markLineWidth + 'px',


handlePixel

igauch requested a review from fengtianze December 15, 2023 08:48

JounQin reviewed Dec 15, 2023

View reviewed changes

Comment thread .changeset/fifty-hounds-stare.md Outdated

JounQin requested changes Dec 15, 2023

View reviewed changes

fengtianze reviewed Dec 15, 2023

View reviewed changes

igauch force-pushed the feat/table-resizeable branch from e9c66f5 to 02593b3 Compare December 29, 2023 03:40

fengtianze reviewed Dec 29, 2023

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin requested changes Dec 29, 2023

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

Comment thread src/table/table-col-resizable.directive.ts Outdated

Comment thread src/table/table-col-resizable.directive.ts Outdated

igauch force-pushed the feat/table-resizeable branch 2 times, most recently from 53e74ec to e41e310 Compare January 2, 2024 06:07

JounQin requested changes Jan 2, 2024

View reviewed changes

igauch force-pushed the feat/table-resizeable branch from e41e310 to e30c12e Compare January 3, 2024 03:11

JounQin requested changes Jan 3, 2024

View reviewed changes

Comment thread scripts/build.js Outdated

Comment thread scripts/build.js Outdated

igauch force-pushed the feat/table-resizeable branch from e30c12e to 51a3266 Compare January 3, 2024 04:20

JounQin requested changes Jan 3, 2024

View reviewed changes

igauch force-pushed the feat/table-resizeable branch 2 times, most recently from f3017e6 to 19f56c9 Compare January 3, 2024 08:02

JounQin requested changes Jan 3, 2024

View reviewed changes

igauch force-pushed the feat/table-resizeable branch from 19f56c9 to 068f7ca Compare January 4, 2024 02:13

JounQin requested changes Jan 4, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin requested changes Jan 4, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin requested changes Jan 4, 2024

View reviewed changes

Comment thread stories/resizable/basic.component.ts Outdated

JounQin reviewed Jan 4, 2024

View reviewed changes

Comment thread src/table/table-col-resizable.directive.ts Outdated

JounQin requested changes Jan 4, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin requested changes Jan 4, 2024

View reviewed changes

Comment thread src/table/table-col-resizable.directive.ts Outdated

JounQin reviewed Jan 4, 2024

View reviewed changes

Comment thread src/table/table-col-resizable.directive.ts Outdated

JounQin reviewed Jan 4, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin reviewed Jan 4, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin reviewed Jan 8, 2024

View reviewed changes

Comment thread src/resizable/resizable.directive.ts Outdated

JounQin reviewed Jan 8, 2024

View reviewed changes

Comment thread src/table/table-col-resizable.directive.ts Outdated

JounQin reviewed Jan 8, 2024

View reviewed changes

Comment thread stories/resizable/basic.stories.ts Outdated

fengtianze force-pushed the feat/table-resizeable branch 9 times, most recently from 0fc75e3 to 787e639 Compare January 17, 2024 16:22

JounQin reviewed Jan 17, 2024

View reviewed changes

Comment thread src/table/table-column-resizable.directive.ts Outdated

JounQin reviewed Jan 17, 2024

View reviewed changes

Comment thread src/table/table-column-resizable.directive.ts

fengtianze force-pushed the feat/table-resizeable branch from 787e639 to 6ce37cd Compare January 18, 2024 02:11

fengtianze changed the title ~~feat: add resizable directive~~ feat: table support resize column width Jan 18, 2024

fengtianze force-pushed the feat/table-resizeable branch from 6ce37cd to ce26bce Compare January 18, 2024 02:48

JounQin reviewed Jan 18, 2024

View reviewed changes

fengtianze force-pushed the feat/table-resizeable branch from ce26bce to b67106f Compare January 18, 2024 03:04

JounQin reviewed Jan 18, 2024

View reviewed changes

Comment thread src/table/table-column-resizable.directive.ts Outdated

JounQin reviewed Jan 18, 2024

View reviewed changes

Comment thread src/table/table-column-resizable.directive.ts

JounQin reviewed Jan 18, 2024

View reviewed changes

Comment thread src/table/table-column-resizable.directive.ts Outdated

JounQin reviewed Jan 18, 2024

View reviewed changes

feat: table support resize column width

6b036ca

fengtianze force-pushed the feat/table-resizeable branch from b67106f to 6b036ca Compare January 18, 2024 03:32

fengtianze merged commit b4a96de into master Jan 18, 2024

fengtianze deleted the feat/table-resizeable branch January 18, 2024 03:33

alaudabot mentioned this pull request Jan 16, 2024

chore: release @alauda/ui #543

Merged

	return parseInt(width.slice(0, -2));
	return Number.parseFloat(width.slice(0, -2));

Conversation

igauch commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

JounQin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengtianze commented Dec 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JounQin commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JounQin Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

JounQin Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

JounQin Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JounQin Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

igauch commented Dec 15, 2023 •

edited

Loading

changeset-bot Bot commented Dec 15, 2023 •

edited

Loading

JounQin commented Jan 4, 2024 •

edited

Loading