fix: known drawer issues - #531
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 811149b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JounQin
reviewed
Dec 14, 2023
JounQin
reviewed
Dec 14, 2023
Collaborator
|
没必要去掉组件内的默认值吧，我看有的地方没通过 Service 来使用抽屉 |
Contributor
Author
组件方式最终也是通过service实现的 |
Collaborator
ok, 我没问题了 |
JounQin
reviewed
Dec 14, 2023
JounQin
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a. 之前是使用 Object.assign(compnent, option)，现在变成服务是唯一打开抽屉方式，组件只是服务的另一个形式，顺序颠倒了，是先组件后服务。所以应该把默认值写到service里，把组件的assign给服务
a. 因为之前使用服务的方式关闭会销毁实例，而组件形式因为有两个overlay，销毁的只是服务的overlay，所以aui-drawer组件本身的overlay并没有被销毁，也就是传入的组件并没有被销毁；
b. 之前两种形式的这种差异没有被清晰的意识到，然后受家忍提出“需要缓存”的影响，就改成关闭不销毁了，包括使用服务的方式。后面在验证的时候也只是验证表单状态是否被保留，而没有验证是否可以正常更新内容导致出现问题
c. 新增 disposeWhenHide 配置，默认值是true，也就是关闭即销毁，但组件里默认是false，与之前的行为保持一致