fix: number-input border blocked - #445
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 133b3d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yangxiaolang
force-pushed
the
fix/number-input-border-blocked
branch
from
February 3, 2023 06:46
0b69ba5 to
133b3d0
Compare
fengtianze
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
border 的值并不是固定的 1px, 会随着浏览器缩放改变,导致之前通过 margin 调整按钮位置的方法会覆盖外层的 border
伪元素也是,通过 width 作为 border, 会在 100% 缩放下比实际 border 要宽