Sitelet https://github.com/alauda/ui/pull/134
Skip to content

fix: detect textarea value changes for autosize - #134

Merged
JounQin merged 1 commit into
masterfrom
fix/autosize
Jun 24, 2021
Merged

JounQin merged 1 commit into
masterfrom
fix/autosize

Conversation

@JounQin

@JounQin JounQin commented Jun 23, 2021

Copy link
Copy Markdown
Member

close #121

@JounQin JounQin added the bug Something isn't working label Jun 23, 2021
@JounQin
JounQin requested a review from fengtianze June 23, 2021 03:06
@JounQin JounQin self-assigned this Jun 23, 2021
@changeset-bot

changeset-bot Bot commented Jun 23, 2021 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 91cd98b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fengtianze

Copy link
Copy Markdown
Collaborator

同时保留新旧两个指令吧

@JounQin

JounQin commented Jun 23, 2021

Copy link
Copy Markdown
Member Author

同时保留新旧两个指令吧

老的指令这种情况就不管了?

@fengtianze

Copy link
Copy Markdown
Collaborator

不管了呗。比直接取消支持好吧

@JounQin

JounQin commented Jun 23, 2021

Copy link
Copy Markdown
Member Author

不管了呗。比直接取消支持好吧

如果本质上没有什么收益感觉没有必要支持,毕竟有隐藏性 bug。

如果只是改下关键字的事情直接在业务代码改下就行了,当然如果所谓『异步』会影响到原来业务代码的逻辑,比如会要求在 submit 前 delay 一下那就都保留下来,这个你可以确认一下。

@JounQin
JounQin merged commit 8453e51 into master Jun 24, 2021
@JounQin
JounQin deleted the fix/autosize branch June 24, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: autosize does not work on async loaded value for first rendering

2 participants