Conversation
aipd506
requested review from
a team,
carloshvp and
zohebk8s
as code owners
September 30, 2026 16:06
Contributor
|
Thanks for this, @aipd506. Closing it for now, and it is not about the change itself. This repository asks first-time contributors to be vouched by a maintainer before opening a pull request. That is because agent-written contributions are easy to produce and expensive to review, and we would rather talk to you first than review something neither of us can explain. To get vouched: open an issue saying what you want to change and why, in your own words. A maintainer will reply, and add you with See CONTRIBUTING.md for the detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Resolves #218:
examples/minimal/README.mdto reference the real pinnedtrusted_root_issuerskey fromca2a-config.yaml(eda38c44...eb162).ca2a-config.yaml.tests/unit/test_example_minimal.pyexecutingca2a verify-chainandca2a validate-configviacli_main, assertingverified: trueandok: provider=software-only enforcement=enforcing.Acceptance Criteria Verification
test_example_minimal.pyruns both commands throughca2a_runtime.cli.mainand asserts output.