Repository navigation
Conversation
The NFe overload hashed the first three characters of the Id, which are the literal NFe, so every invoice with the same CSRT got the same hash.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashCSRT(csrt, nfe) took the first three characters of infNFe.Id. That Id is the literal NFe plus the 44-digit access key, so the hash was SHA-1 of the CSRT plus NFe. Every invoice that shared a CSRT got the same hashCSRT.
The prefix is removed and the 44-digit key is hashed, which is what the overload that already takes a key does. Before the change those two hashes differed (HC/Q9KgMAT07npVfffbsGxhXQNU= and ZEKmfGihmC0BWaMUN1QN4uWoZv4=). After it they match.
Test plan
Made with Cursor