✨ LibBytes indexOfByte - #1425
Merged
Merged
Conversation
Vectorized
marked this pull request as ready for review
June 6, 2025 03:02
Owner
|
looks good. I might cache the mask in a variable to make the bytecode smaller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
function indexOfByte(bytes memory subject, bytes1 needle, uint256 from)and offset-less shortcut toLibBytesandLibString.This is a considerably more optimal version of
indexOfin the case only a byte needle is used as we can apply some learnings from bithacks and keep the gas cost per 'missed' chunk quite low.The reason for naming it
indexOfByteversus keeping it asindexOfis because Solidity also tries to cast literal strings tobytes1, so if there's an implementation forbytesand one forbytes1, the user always has to be explicit on the type, which can get annoying.Reproduced the
clzimplementation inside of it to avoid creating a dependency just for that and for a very small optimization, but it would be okay to do otherwise as well.(Keeping it as draft for a review soon, and possibly some more tests.)
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?