Added Baklava in Kotlin Article - #375
Conversation
|
Fixed #192 |
jrg94
left a comment
There was a problem hiding this comment.
Looks great! Any chance you'd want to help with the featured images? It's pretty easy to do. I usually just pick something from here: https://pixabay.com/
Then, you can drop the image in the assets/sources/ folder, and the CI will generate the titled image for you. (Don't forget to put the file name in the header here.)
|
Looks like it needs write access to generate all the images? |
|
Interesting! Is it because you added the files? Let me see if I can set this up to always push as me. |
|
I'm going to try rerunning it. If that doesn't work, I'll add you to core. If that doesn't work, I'll try committing as myself. |
|
Actually, this shouldn't be an issue since it commits to the current branch... hmmmm! I thought maybe the issue was pushing to master which is protected. Maybe because the changes are on a fork? |
|
Can you try pulling from master? I'm seeing this: Not sure what this means. |
|
Error: Error: Pushing to https://github.com/TheRenegadeCoder/sample-programs-website |
|
I saw that error, but the error I posted happens even before that. I think it's possibly a fork issue. I'll investigate a bit more. Author appears to be null. Let me force it as me. |
|
Can you try pulling from master once more? |
|
I really think this has something to do with you being on a fork. It looks like it's trying to push to Master on this repo despite the change being on your repo. That's why it can't find a commit to work from. I'll sent a bug report out to the author of the tool. Perhaps they can shed some light on it. |
|
I'm going to merge this. The website build will likely fail, so I will make a separate pull request with an additional source image. |
Thanks for helping us build up our knowledge base!
What kind of pull request hav you brought us today?
Pull Request Type
Notes
Feel free to share any details you feel are relevant.