Added Duplicate Character Counter in Every Language Article - #334
Conversation
jrg94
left a comment
There was a problem hiding this comment.
Looks good! A couple quick changes, and I think we'll be good to go.
|
Think I got it all :) |
jrg94
left a comment
There was a problem hiding this comment.
This is awesome! I have a quick question about the output. Also, did you mean to delete the article? It looked like there were two of them, but one of them was fine.
jrg94
left a comment
There was a problem hiding this comment.
Looks great! I just have one last question about the format of the output, so we can begin writing up the testing.
Co-authored-by: Jeremy Grifski <jeremy.grifski@gmail.com>
Yeah, it's meant to be separate lines, but the formatting above broke the table for me. |
|
You're 100% right! Here's how we did it for fibonacci: https://raw.githubusercontent.com/TheRenegadeCoder/sample-programs-website/master/projects/fibonacci/index.md Maybe, we can use |
jrg94
left a comment
There was a problem hiding this comment.
We're in great shape! Did you ever add yourself to the authors file? https://github.com/TheRenegadeCoder/sample-programs-website/blob/master/_data/authors.yml
|
Woah that was weird timing! |
|
Ok awesome! I think I got it all sorted |
|
lmao that was really weird |
|
I'll go ahead and add myself to the authors rn haha |
|
Thanks a bunch for being patient and helping me so much! I know a little markdown now as a result lol |
|
Oh no problem! I was actually a bit more worried that this was too complicated. Let me know if there's anything we can do to simplify this process more. |
|
Is everything set for a merge? :) |
|
We're missing your entry in the author.yml file, I think. @GoodbyeBlues |
|
Just added it. My bad, I tried making a pull request for that a while ago but I guess it didn't go through! |
If any changes are needed, let me know!