Sitelet https://github.com/Strategy11/formidable-forms/pull/3514
Skip to content

Try to fix form templates e2e test - #3514

Merged
Crabcyborg merged 1 commit into
masterfrom
try_to_fix_formtemplates_e2e_test
Sep 29, 2026
Merged

Try to fix form templates e2e test#3514
Crabcyborg merged 1 commit into
masterfrom
try_to_fix_formtemplates_e2e_test

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Sep 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #3401

Summary by CodeRabbit

  • Tests
    • Updated the Contact Us template test to verify that using the template opens the form editor.

@Crabcyborg Crabcyborg added the run e2e tests Run the Cypress end-to-end suite on this PR label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a9f55339-31cd-41fd-b6e7-d4646094b82f

📥 Commits

Reviewing files that changed from the base of the PR and between 1004449 and 8cbf47d.

📒 Files selected for processing (1)
  • tests/cypress/e2e/Form Templates/FormTemplates.cy.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The Contact Us template test now verifies that using the template navigates to the edit URL and displays the form editor. It no longer checks or clicks the close icon.

Changes

Template use test

Layer / File(s) Summary
Verify editor navigation
tests/cypress/e2e/Form Templates/FormTemplates.cy.js		 After clicking “Use Template,” the test checks that the URL contains frm_action=edit and that the form editor is visible.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 8cbf4

This change adjusts Cypress verification of template navigation without changing application behavior. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 8cbf4

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/cypress/e2e/Form Templates/FormTemplates.cy.js: After clicking “Use Template” for Contact Us, the test checks that the URL search contains frm_action=edit within 10 seconds and that the form editor container is visible; it no longer checks for or clicks a visible close icon.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change: an attempted fix for the form templates end-to-end test. It is concise and related to the changeset.
Linked Issues check ✅ Passed The PR changes the affected Cypress test for #3401. It removes the failing svg[aria-label="Close"] visibility and click assertion. After Use Template, it waits up to 10 seconds for `frm_action=edi…
Out of Scope Changes check ✅ Passed The whole-PR diff contains only the affected Cypress test. The new URL and editor assertions support the template-use objective in #3401. No unrelated production or test changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Crabcyborg
Crabcyborg merged commit 8ed6fa1 into master Sep 29, 2026
34 of 38 checks passed
@Crabcyborg
Crabcyborg deleted the try_to_fix_formtemplates_e2e_test branch September 29, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run e2e tests Run the Cypress end-to-end suite on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FormTemplates.cy.js: 'add templates as favorites, view demo and use templates' — modal not visible in time

1 participant

@Crabcyborg