Sitelet https://github.com/Strategy11/formidable-forms/pull/3391
Skip to content

Add JS hook to phase out new logic row JS from lite - #3391

Merged
Crabcyborg merged 1 commit into
masterfrom
add_js_hook_to_phase_out_new_logic_row_js_from_lite
Sep 19, 2026
Merged

Add JS hook to phase out new logic row JS from lite#3391
Crabcyborg merged 1 commit into
masterfrom
add_js_hook_to_phase_out_new_logic_row_js_from_lite

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Sep 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated logic-row handling to support compatibility with the Pro version when adding condition rows.
    • The fallback behavior can now be controlled to prevent conflicting logic-row handlers.

@Crabcyborg Crabcyborg added this to the 6.36 milestone Sep 19, 2026
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 062c9cf3-e6cd-47ab-9d2e-7a323577f6a5

📥 Commits

Reviewing files that changed from the base of the PR and between 34d8b77 and 08c79ee.

📒 Files selected for processing (2)
  • js/formidable_admin.js
  • js/src/admin/admin.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The admin builder now checks frm_should_add_logic_row_in_lite before attaching the Lite logic row handler. A falsy filter result prevents Lite from registering the handler.

Changes

Logic row handler registration

Layer / File(s) Summary
Conditional handler registration
js/src/admin/admin.js		 The .frm_add_logic_row click handler is attached only when the frm_should_add_logic_row_in_lite filter returns a truthy value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Suggested reviewers: truongwp

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a JavaScript hook that allows Formidable Pro to phase out the Lite logic-row handler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 34d8b77...08c79ee on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 19, 2026 12:58a.m. Review ↗
JavaScript Sep 19, 2026 12:58a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg
Crabcyborg merged commit 0027085 into master Sep 19, 2026
23 of 33 checks passed
@Crabcyborg
Crabcyborg deleted the add_js_hook_to_phase_out_new_logic_row_js_from_lite branch September 19, 2026 01:01
@robin-the-going-merry robin-the-going-merry Bot mentioned this pull request Sep 19, 2026
Closed
@vivi-the-going-merry vivi-the-going-merry Bot mentioned this pull request Sep 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run analysis

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

1 participant

@Crabcyborg