Remove Cartopy build-time dependencies - #448
Merged
Merged
Conversation
Member
|
Does Cartopy need proj and geos? We should update the "how to install cartopy" section here: https://github.com/QuLogic/SHTOOLS/blob/no-cartopy-deps/docs/pages/mydoc/python-installing.md If this is all moot, we can just delete the whole section. |
Member
Author
|
That's all hidden behind |
Latest Cartopy produces wheels, so there's no need to install its build-time dependencies ourselves.
QuLogic
force-pushed
the
no-cartopy-deps
branch
from
February 28, 2024 00:13
082aa6a to
33e086d
Compare
Member
|
looks good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest Cartopy produces wheels, so there's no need to install its build-time dependencies ourselves.
Reminders
developbranch: themasterbranch is used only when releasing new versions.make checkto ensure that the python code follows standard formatting conventions.