Drop the last two lint expectations clippy 1.98 no longer fulfils - #8568
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe change removes ChangesClippy lint cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR removes two obsolete lint expectations while leaving the guarded code unchanged, so it does not alter product behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a545eef to
2c0715f
Compare
Assisted-by: Claude Code:claude-opus-5
2c0715f to
212318f
Compare
Summary
#8564 removed four
#[expect(clippy::std_instead_of_core)]that clippy 1.98 stoppedfulfilling. Two more were left behind, and each hid behind a
cfgthat the job whichwould have reported it did not compile.
crates/vm/src/stdlib/_signal.rsis gated on#[cfg(windows)], so only the Windows jobsees it. It showed up on #8564's own last run, once the other four were gone:
crates/host_env/src/posix.rsis gated onnot(any(linux, haiku, solaris, illumos, hurd)),so among the CI runners only macOS compiles it. It stayed quiet until #8564 landed because
clippy reports one error per crate, and the
fopenexpectation in the same crate camefirst. It surfaced on main right after the merge:
Only the attributes go; the
cfgon each statement stays.Testing
cargo fmt --checkand the workspace clippy with the flags from the CI job both pass onLinux, so the side that was already green is undisturbed. I do not have a Rust toolchain on
Windows or macOS, so I did not reproduce either of those two jobs myself. The quoted errors
are from your CI rather than from my machine, and your CI is what will confirm the fix.
AI assistance
Claude Code (claude-opus-5) was used throughout: reading the CI logs to locate the two
expectations, making the deletions, and running fmt and clippy on Linux. I reviewed the
diff and the policy before opening this.
Summary by CodeRabbit