x509-cert: make Builder::assemble() take in an AlgorithmIdentifier instead of a signer - #2440
Closed
cuddleworks wants to merge 1 commit into
Closed
cuddleworks wants to merge 1 commit into
cuddleworks wants to merge 1 commit into
Conversation
…stead of a signer
Member
|
Can you share a bit about your use-case? I'm not sure I follow what you're trying to do. You're not really meant to call Also: This is breaking change and this will have to wait the next release-cycle. EDIT: if that is #2439 to build a certificate from existing part, this is not supported by this crate, and I don't believe we mean to support that. Your best option is likely to make your own Certificate implementation and #[derive(der::Sequence)] with it. |
Author
|
I see, I misunderstood the intended use of this crate. Thanks for clarifying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that one can build a
Certificatewithout needing to create a dummy signer, it also aligns the function signature more to what it actually does.This PR also contains a change in
cms, due tocmsdepending on the Builder trait.