tls_codec: return an error instead of panicking on truncated VLBytes - #2414
Open
WorkingRobot wants to merge 1 commit into
Open
WorkingRobot wants to merge 1 commit into
WorkingRobot wants to merge 1 commit into
Conversation
Signed-off-by: Asriel Camora <asriel@camora.dev>
franziskuskiefer
requested changes
Sep 28, 2026
franziskuskiefer
left a comment
Contributor
There was a problem hiding this comment.
Why do you want an error in this case? Panicking is what allows you to debug.
Author
|
It means that I can't properly test over-the-wire runs in debug mode. If I want a panic, I can easily add a .unwrap(). Having it panic in debug mode really only makes sense when the library has a logic error. If it helps, I'm using tls_codec for an MLS implementation, not for TLS. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode,
VLBytes::tls_deserialize_bytesandVLByteVec::tls_deserialize_bytespanic instead of returning an Err. Panics should happen on invariants, not on untrusted input.