include <algorithm> in tbb/concurrent_queue.h - #280
Merged
Conversation
libc++ trunk no longer pulls <algorithm> in transitively, so the std::equal used by concurrent_queue/concurrent_bounded_queue operator== fails to resolve on CRAN's clang-trunk checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAN's clang-trunk (clang 23) checks fail to install RcppParallel:
https://www.stats.ox.ac.uk/pub/bdr/clang23/RcppParallel.log
concurrent_queue.husesstd::equalin theoperator==of bothconcurrent_queueandconcurrent_bounded_queue, but never includes<algorithm>-- it relied on some other header dragging it in. libc++ trunk nolonger does, so compiling
src/tbb/concurrent_bounded_queue.cppfails and takesthe whole bundled oneTBB build down with it.
Adds the include, and records it in
patches/so it survives the nexttools/tbb/update-tbb.Rrun.Notes
once it is.
src/tbbfor<algorithm>/<numeric>functionsused without the include (
std::max/std::minincluded) --concurrent_queue.hwas the only one.concurrent_vector.h,concurrent_lru_cache.h,blocked_rangeNd.handparallel_sort.halreadyinclude it explicitly.
-Wunused-template,-Wunused-private-field) is from BDR's extra warning flags on upstream TBBcode, not errors, and is left alone.
Verification
git apply --check --reversepasses for all seven files inpatches/.actually failed on CRAN (
src/tbb/src/tbb/concurrent_bounded_queue.cpp).