Add signing manifest and script to update it with production values - #5397
Merged
Travis Plunk (TravisEz13) merged 3 commits intoNov 10, 2017
Merged
Conversation
Travis Plunk (TravisEz13)
requested review from
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
November 9, 2017 20:27
Dongbo Wang (daxian-dbw)
approved these changes
Nov 9, 2017
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
LGTM. Some comments left.
| @@ -0,0 +1,49 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <SignConfigXML> | |||
| <!-- ****Begin**** Should be BothDual - Dual (Sha256 and Sha1) AuthenticodeDual) and StrongName ******** --> | |||
There was a problem hiding this comment.
"StorngName" is gone
|
|
||
|
|
||
| <!-- | ||
| <file src="__INPATHROOT__\Install-PowerShellRemoting.ps1" signType="AuthenticodeDual" dest="__OUTPATHROOT__\Install-PowerShellRemoting.ps1" /> |
There was a problem hiding this comment.
This script is not in the parent folder of publish. File an issue.
There was a problem hiding this comment.
Another ps1 file is coming for etw provider.
| <!-- | ||
| <file src="__INPATHROOT__\Install-PowerShellRemoting.ps1" signType="AuthenticodeDual" dest="__OUTPATHROOT__\Install-PowerShellRemoting.ps1" /> | ||
| --> | ||
| <!-- ****Begin**** Authenticode - Authenticode SHA256 ************* --> |
There was a problem hiding this comment.
Add a comment why those files cannot be dual signed (they are scripts)
| $signingXml = [xml](Get-Content $signingXmlPath) | ||
|
|
||
| # Get any variables to updating 'signType' in the XML | ||
| # Define a varabile named `<signTypeInXml>SignType' in VSTS to updating that signing type |
There was a problem hiding this comment.
Add a concrete example.
Dongbo Wang (daxian-dbw)
approved these changes
Nov 9, 2017
Aditya Patwardhan (adityapatwardhan)
approved these changes
Nov 9, 2017
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…owerShell#5397) * Add signing configuration file * add updatesigning.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.