Sitelet https://github.com/PowerDNS/pdns/pull/17870
Skip to content

auth: http api fixes - #17870

Open
miodvallat wants to merge 4 commits into
PowerDNS:masterfrom
miodvallat:rtfm
Open

auth: http api fixes#17870
miodvallat wants to merge 4 commits into
PowerDNS:masterfrom
miodvallat:rtfm

Conversation

@miodvallat

@miodvallat miodvallat commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Short description

This PR addresses recent reports of documentation inaccuracies.

  • it fixes the documentation to not show zone contents reported in the "list all zones" operation.
  • it removes a non-working, undocumented endpoint from the code
  • it removes a documented, never implemented endpoint from the documentation

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@miodvallat

miodvallat commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Fixes: #17834

@coveralls

coveralls commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 32386021008

Coverage increased (+4.1%) to 71.192%

Details

  • Coverage increased (+4.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 55 coverage regressions across 9 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

55 previously-covered lines in 9 files lost coverage.

File Lines Losing Coverage Coverage
pdns/recursordist/rec-system-resolve.cc 19 49.32%
pdns/recursordist/test-syncres_cc1.cc 8 80.18%
pdns/dnsdistdist/dnsdist-tcp.cc 7 74.87%
pdns/rcpgenerator.cc 5 88.84%
pdns/recursordist/syncres.cc 5 81.37%
modules/gpgsqlbackend/spgsql.cc 3 63.56%
pdns/opensslsigners.cc 3 61.53%
pdns/recursordist/test-syncres_cc2.cc 3 79.35%
modules/lmdbbackend/lmdbbackend.cc 2 72.28%

Coverage Stats

Coverage Status
Relevant Lines: 173282
Covered Lines: 135274
Line Coverage: 78.07%
Relevant Branches: 82908
Covered Branches: 47114
Branch Coverage: 56.83%
Branches in Coverage %: Yes
Coverage Strength: 6813269.7 hits per line
💛 - Coveralls

Habbie
Habbie reviewed Aug 9, 2026
View reviewed changes
Comment thread docs/http-api/openapi/authoritative-api-openapi.yaml Outdated
Comment thread docs/http-api/openapi/authoritative-api-openapi.yaml
@miodvallat
Use the symbolic array types whenever possible.
c8784a8 
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@miodvallat
Declare a "ZoneWithoutRRSet" object, to use for answers which lack RR…
c9c3b69 
…Sets.

This makes the generated example for the GET .../zones endpoint closer
to reality.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@miodvallat
Remove .../config/{config_setting_name} endpoint documentation.
3efe4d6 
As far as I can tell, it has never been implemented.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
@miodvallat
Remove POST endpoint for .../cryptokeys/<key_id>.
fb15b4e 
It would behave as POST on .../cryptokeys and wasn't documented anyway.

Fixes: PowerDNS#17807

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Habbie Habbie Habbie approved these changes

Assignees

No one assigned

Labels

auth docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miodvallat @coveralls @Habbie