Refresh property socket preview constantly - #1673
Open
Ghoti-tpt wants to merge 4 commits into
Open
Conversation
flabbet
approved these changes
Aug 17, 2026
flabbet
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I'll run clanker to see if there any obvious issues I've missed
There was a problem hiding this comment.
Pull request overview
This PR changes node-property socket previews so the currently hovered property’s computed value is kept up-to-date on every node graph update (instead of only refreshing once on initial hover), improving the accuracy of socket preview tooltips.
Changes:
- Add “watch” semantics for computed property values (start on pointer enter, stop on pointer exit / visual detach).
- Refresh watched computed values after each node graph update/render cycle.
- Improve computed-value string formatting by resolving
ShaderExpressionVariableconstants.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PixiEditor/Views/Nodes/Properties/NodeSocket.cs | Starts/stops watching a property’s computed value based on pointer hover and visual-tree detach. |
| src/PixiEditor/ViewModels/SubViewModels/NodeGraphManagerViewModel.cs | Adds internal commands to start/stop watching computed values via the active document’s node graph. |
| src/PixiEditor/ViewModels/Nodes/NodePropertyViewModel.cs | Exposes Start/StopWatchingComputedValue methods on the property view model. |
| src/PixiEditor/ViewModels/Document/NodeGraphViewModel.cs | Stores watched properties and updates their computed values during graph updates. |
| src/PixiEditor/Models/Handlers/INodePropertyHandler.cs | Extends the property handler contract with start/stop watching methods. |
| src/PixiEditor/Models/Handlers/INodeGraphHandler.cs | Extends the graph handler contract with UpdateWatchedComputedValues(). |
| src/PixiEditor/Models/DocumentModels/ActionAccumulator.cs | Calls UpdateWatchedComputedValues() after renders/updates complete. |
| src/PixiEditor/Helpers/Converters/ComputedValueToStringConverter.cs | Resolves ShaderExpressionVariable to constants before formatting. |
Suppressed comments (1)
src/PixiEditor/Models/DocumentModels/ActionAccumulator.cs:318
- Same as above: this finally block can run after rendering throws ObjectDisposedException and the document/tracker may already be disposed. Guard UpdateWatchedComputedValues to avoid unexpected exceptions during teardown.
finally
{
NotifyUpdatedPreviews(updatePreviewActions);
document.NodeGraphHandler.UpdateWatchedComputedValues();
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+408
to
+420
| public void UpdateWatchedComputedValues() | ||
| { | ||
| if (watchedProperties.Count == 0) | ||
| return; | ||
|
|
||
| DrawingBackendApi.Current.RenderingDispatcher.Invoke(() => | ||
| { | ||
| foreach (var property in watchedProperties) | ||
| { | ||
| property.InternalSetComputedValue(GetComputedPropertyValue<object>(property)); | ||
| } | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
yep, you should snapshot watchedProperties before enumerating
Comment on lines
208
to
212
| finally | ||
| { | ||
| NotifyUpdatedPreviews(updatePreviewActions); | ||
| document.NodeGraphHandler.UpdateWatchedComputedValues(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearly describe changes, as detailed as possible
The property socket currently previewed will refresh every node graph update instead of on first mouse over.
If possible, show examples of usage
20260728-2059-07.6453452.mp4
SELECT BELOW TO CONTINUE