Sitelet https://github.com/OpenSourceBrain/OSBv2/pull/922
Skip to content

#920 - fix latency in typing in search box - #922

Merged
filippomc merged 1 commit into
developfrom
feature/920
Mar 26, 2024
Merged

#920 - fix latency in typing in search box#922
filippomc merged 1 commit into
developfrom
feature/920

Conversation

@D-GopalKrishna

@D-GopalKrishna D-GopalKrishna commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

This PR addresses issue #920 by optimizing the search functionality in the Repositories and Workspaces page.

Changes made:

  • Previously, the setSearchFilterValues function was debounced by 500ms. This caused a delay in the UI response, making the search feel slow.
  • The debounce has been moved to the API call instead. Now, setSearchFilterValues updates the state immediately for a faster UI response, while the API call is debounced.

filippomc
filippomc approved these changes Mar 26, 2024
View reviewed changes

@filippomc filippomc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc
filippomc merged commit 12d26d8 into develop Mar 26, 2024
@filippomc
filippomc deleted the feature/920 branch March 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filippomc filippomc filippomc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@D-GopalKrishna @filippomc