Sitelet https://github.com/OpenSourceBrain/OSBv2/pull/892
Skip to content

Fix/GitHub copy: more robustly handle git config bits - #892

Merged
filippomc merged 2 commits into
developfrom
fix/github-copy
Jan 19, 2024
Merged

filippomc merged 2 commits into
developfrom
fix/github-copy

Conversation

@sanjayankur31

Copy link
Copy Markdown
Collaborator

No description provided.

If it's unset, it will read the value from global git config, but if
it's blank, it won't. If the user does have a global git config, we want
that to work.
@sanjayankur31 sanjayankur31 added C: backend backend related D: live On the live deployment D: development On development deployment labels Jan 19, 2024

@filippomc filippomc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filippomc
filippomc merged commit b97ac9b into develop Jan 19, 2024
@filippomc
filippomc deleted the fix/github-copy branch January 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: backend backend related D: development On development deployment D: live On the live deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants