Sitelet https://github.com/OpenSourceBrain/OSBv2/pull/711
Skip to content

fixed tests considering new UI - #711

Merged
filippomc merged 2 commits into
developfrom
feature/fixTests
Mar 24, 2023
Merged

filippomc merged 2 commits into
developfrom
feature/fixTests

Conversation

@SimaoBolota-MetaCell

@SimaoBolota-MetaCell SimaoBolota-MetaCell commented Mar 24, 2023 •

Copy link
Copy Markdown
Contributor

What changes with this PR

This PR addresses the changes in the UI, making the according changes in the test flow and HTML selectors used.

Besides the new UI, some features were added such as

  • when the maximum number of servers is reached, the servers are stopped, deleted and a new one is re-started
  • when leaving the NetPyNE app inside OSB a 'Leave' dialog is prompted. For this reason, code to handle this dialog was also added

Example:

Screen.Recording.2023-03-24.at.16.34.55.mov

(Note: The 'Leave' dialog when exiting NetPyNE remains visible but is being handled in the background as you can see from the application continuing its testing process)

@SimaoBolota-MetaCell
SimaoBolota-MetaCell marked this pull request as ready for review March 24, 2023 16:38

@filippomc filippomc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@filippomc
filippomc merged commit 90da568 into develop Mar 24, 2023
@filippomc
filippomc deleted the feature/fixTests branch March 24, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants