Re-resolve the v1.12 default manifest so SimpleKiteControllers precompiles from the workspace projects by 1-Bort-1 · Pull Request #16 · OpenSourceAWE/SimpleKiteControllers.jl

1-Bort-1 · 2026-10-06T18:19:30Z

TL;DR

Manifest-v1.12.toml.default is re-resolved against the current Project.tomls. SimpleKiteControllers' entry now lists DocStringExtensions, Documenter and its deps for docs/ are included, and MakieControlPlots meets main's new 0.1.20 bound. The v1.13 .default needed the same fix, and main's 00d466c has since made it, so this branch now carries main's copy unchanged.

What was wrong

With the root project active, Julia reads SimpleKiteControllers' deps from its own Project.toml, so the package loads fine there. From a workspace member (examples/, test/, docs/) Julia reads them from the manifest entry instead, and that entry did not list DocStringExtensions after 0f219c3 added it. Reproduced in the session with examples active and Base.compilecache on SimpleKiteControllers:

ArgumentError: Cannot load (using/import) module DocStringExtensions into module SimpleKiteControllers in package SimpleKiteControllers because package SimpleKiteControllers does not have DocStringExtensions in its dependencies

v1.13: fixed on main

Merging main conflicted on Manifest-v1.13.toml.default. Main's 00d466c re-resolved it under 1.13.1: its SimpleKiteControllers entry lists DocStringExtensions, Documenter is present, and it is resolved against the MakieControlPlots bump. I kept main's copy verbatim. Seeding the live manifest from it and running Pkg.resolve() on the box's 1.13.0 moves no package. The only differences are julia_version and the LibSSH2_jll stdlib (1.13.1 vs 1.13.0) and project_hash, so nothing goes back into the .default.

v1.12: the change this PR carries

Minimal resolve under 1.12.7 (julia +1.12), seeded from the tracked .default:

[[deps.SimpleKiteControllers]] gains DocStringExtensions.
New: Documenter 1.19.0 plus Git, Git_jll, Git_LFS_jll, IOCapture, LazilyInitializedFields, MarkdownAST, OpenSSH_jll and RegistryInstances, all of them only for docs/Project.toml.
WinchControllers was tracked at path = "/home/ufechner/repos/WinchControllers", so the .default could not be installed on any other machine: expected package WinchControllers [9e74470a] to exist at path .... That is §2's "already unsatisfiable" case, so the resolve widened by one Pkg.free("WinchControllers"). It stays at v0.6.4, now the registered release.
MakieControlPlots 0.1.19 → 0.1.20, forced by main's examples/Project.toml compat bump (ada6119). Pkg.resolve() refuses to move a manifest pin that violates compat (empty intersection between MakieControlPlots@0.1.19 and project compatibility 0.1.20 - 0.1), so this one went through Pkg.update("MakieControlPlots"; preserve = PRESERVE_ALL). Nothing else moved.
Bonito's and CommonMark's weakdeps go from table form to list form. This is Pkg reformatting the same data.

Also fixed

CLAUDE.md said the workspace was ["examples"] and that there was no docs/make.jl or docs/Project.toml. Both lines now describe the examples/test/docs workspace and how the docs are built.

Verification

Reproduced first (1.13.0, examples active): Cannot load ... DocStringExtensions into module SimpleKiteControllers .... On 1.12.7 the old .default does not get as far as resolving, because of the WinchControllers path.
After the merge: Base.compilecache(SimpleKiteControllers) with examples active → OK on 1.13.0 (juliaserver, main's .default). On 1.12.7 (julia +1.12 --project=.) the resolve precompiled SimpleKiteControllers ✓.
include("test/runtests.jl") after the merge: 1585/1585 pass in 1m34 (juliaserver, examples env, 1.13.0)
Local CI mirror (agent ci-local, Pkg.test on 1.13.0): started on the merge commit, result not in yet · GitHub CI: pending
Docs build (previous round, before the merge): include("docs/make.jl") with docs active, clean. Not re-run after the merge, which left docs/ and the 1.13 docs deps alone · REUSE: n/a, this repo has no bin/reuse_lint · Changelog: none, because the manifests are not part of a release
Risk: v1.12 was resolved on 1.12.7 only. Nothing exercises it in CI here, which runs on 1.13.

Scope

+67 / -20 across 2 files against main: Manifest-v1.12.toml.default (+60 / -13), plus 7 lines of CLAUDE.md rewritten to describe the workspace.

Opened by 1-Bort-1, an AI agent working for @1-Bart-1.
Closes #15 · task SimpleKiteControllers.jl-15

Both .defaults predated DocStringExtensions in [deps] and Documenter in docs/Project.toml, so SimpleKiteControllers failed to precompile from any workspace project. The v1.12 one also tracked WinchControllers at a local path on another machine; it is freed to the registered v0.6.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1-Bort-1

Independent review (advisory)

Verdict: APPROVE WITH COMMENTS · 1 inline, 0 off the diff

Good

Fixes the real fault: both [[deps.SimpleKiteControllers]] entries now list DocStringExtensions, which the root Project.toml declares. That is the dep a workspace member reads from the manifest.
Documenter and its deps are justified: docs/Project.toml exists, is a [workspace] member and depends on Documenter 1.11+. The new entries are its closure and nothing more.
Freeing WinchControllers in v1.12 is the correct, minimal widening. The path /home/ufechner/... could not be installed anywhere else, the version stays at 0.6.4, and it now has a git-tree-sha1 instead of the path.
Only the two tracked .default files are touched, as §9 requires. No Manifest-v*.toml or other files are committed (checked with git show --stat HEAD).
The weakdeps change from table form to list form is Pkg reformatting the same data, and the card says so.

Not good

Manifest-v1.13.toml.default:3 — Resolving on a 1.13.0 box moves the tracked default backwards, from 1.13.1 to 1.13.0, and drags LibSSH2_jll back to 1.11.103 (line 1913). Every 1.13.1 user will then see churn on their next resolve. Resolving on 1.13.1 would have avoided this ping-pong.
The card's Scope line says +129/-23, but the commit is +126/-23 (git show --stat). It's a small error, but the reviewer relies on that line.
CLAUDE.md is now visibly out of date on the very thing this PR fixes: it says there is no docs/make.jl/docs/Project.toml and that [workspace] projects = ["examples"]. It is outside this diff, but it should be noted or get an issue.
Docs build: not run is reasonable, since no docstring changed. But the PR adds Documenter to the manifests precisely so docs/ can install, so instantiating --project=docs once would have verified that claim directly.
Both manifests now carry the same project_hash. That is consistent with one workspace, but the card doesn't mention it.

_{claude, rubric CLEAN_CODE.md. A different lab from the implementer

on purpose: a reviewer sharing its blind spots would not flag its mistakes.}

1-Bort-1 · 2026-10-06T18:21:19Z

Local full suite: PASS (2 min, Julia 1.13.0, one cell of the matrix)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

codecov-commenter · 2026-10-06T18:27:05Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Manifest-v1.13.toml.default conflicted: main's 00d466c re-resolved it under 1.13.1 and already lists DocStringExtensions for SimpleKiteControllers, so main's copy is kept. Manifest-v1.12.toml.default moves MakieControlPlots 0.1.19 -> 0.1.20 to meet main's new examples/Project.toml compat bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1-Bort-1 added agent:running Agent task state agent:ci Agent task state and removed agent:running Agent task state labels Oct 6, 2026

1-Bort-1 commented Oct 6, 2026

View reviewed changes

Comment thread Manifest-v1.13.toml.default Outdated

1-Bort-1 added agent:queued Agent task state agent:running Agent task state and removed agent:ci Agent task state agent:queued Agent task state labels Oct 6, 2026

CLAUDE.md: describe the docs and test workspace members

28e02cd

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1-Bort-1 added agent:ci Agent task state and removed agent:running Agent task state labels Oct 6, 2026

1-Bort-1 marked this pull request as ready for review October 6, 2026 19:08

1-Bort-1 added agent:review Agent task state and removed agent:ci Agent task state labels Oct 6, 2026

1-Bort-1 requested a review from 1-Bart-1 October 6, 2026 19:09

1-Bort-1 added agent:queued Agent task state agent:running Agent task state and removed agent:review Agent task state agent:queued Agent task state labels Oct 7, 2026

1-Bort-1 changed the title ~~Re-resolve both default manifests so SimpleKiteControllers precompiles from the workspace projects~~ Re-resolve the v1.12 default manifest so SimpleKiteControllers precompiles from the workspace projects Oct 7, 2026

1-Bort-1 added agent:ci Agent task state agent:review Agent task state and removed agent:running Agent task state agent:ci Agent task state labels Oct 7, 2026

Navigation Menu

Repository navigation

Re-resolve the v1.12 default manifest so SimpleKiteControllers precompiles from the workspace projects - #16

Re-resolve the v1.12 default manifest so SimpleKiteControllers precompiles from the workspace projects#16
1-Bort-1 wants to merge 3 commits into
mainfrom
agent/15-re-resolve-manifest-v1-13-toml-default-s

1-Bort-1 commented Oct 6, 2026 •

edited

Loading

Uh oh!

1-Bort-1 left a comment

Uh oh!

Uh oh!

1-Bort-1 commented Oct 6, 2026

Uh oh!

codecov-commenter commented Oct 6, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

1-Bort-1 commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

What was wrong

v1.13: fixed on main

v1.12: the change this PR carries

Also fixed

Verification

Scope

Uh oh!

1-Bort-1 left a comment

Choose a reason for hiding this comment

Independent review (advisory)

Uh oh!

Uh oh!

1-Bort-1 commented Oct 6, 2026

Uh oh!

codecov-commenter commented Oct 6, 2026

Welcome to Codecov 🎉

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

1-Bort-1 commented Oct 6, 2026 •

edited

Loading