Conversation
Retag public section headings to remove native outline skips, retarget the affected CSS selectors, and add deterministic hierarchy coverage. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
📝 WalkthroughWalkthroughThe change corrects heading levels across four public pages, updates matching CSS selectors, adds heading hierarchy regression tests, and runs those tests through the npm test workflow. ChangesHeading hierarchy
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/agents.css`:
- Line 19: Update the .gatebox h2 font-family declaration to use the unquoted
Fraunces identifier, preserving the existing serif fallback and all other
typography properties.
In `@public/specimen.css`:
- Line 20: Update the .notrun h3 font-family declaration to use the unquoted
Fraunces identifier, removing only the unnecessary quotes while preserving the
existing fallback and other styling.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ae870910-1b7e-45c7-a4c6-05d037ee566d
📒 Files selected for processing (10)
package.jsonpublic/agents.csspublic/agents.htmlpublic/index.csspublic/index.htmlpublic/pricing.csspublic/pricing.htmlpublic/specimen.csspublic/specimen.htmlscripts/test-heading-hierarchy.mjs
| .gatebox>div{padding:38px 42px} | ||
| .gatebox>div:first-child{border-right:1px solid var(--line)} | ||
| .gatebox h4{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} | ||
| .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the unnecessary font-family quotes.
Stylelint reports font-family-name-quotes on Line 19. Use the unquoted identifier to satisfy the enabled rule.
Proposed fix
- .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em}
+ .gatebox h2{font-family:Fraunces,serif;font-weight:300;font-size:25px;letter-spacing:-.02em}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .gatebox h2{font-family:'Fraunces',serif;font-weight:300;font-size:25px;letter-spacing:-.02em} | |
| .gatebox h2{font-family:Fraunces,serif;font-weight:300;font-size:25px;letter-spacing:-.02em} |
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 19-19: Expected no quotes around "Fraunces" (font-family-name-quotes)
(font-family-name-quotes)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@public/agents.css` at line 19, Update the .gatebox h2 font-family declaration
to use the unquoted Fraunces identifier, preserving the existing serif fallback
and all other typography properties.
Source: Linters/SAST tools
| .notrun{margin-top:40px;background:rgba(176,74,46,.05);border:1px solid rgba(176,74,46,.22); | ||
| border-radius:10px;padding:26px 30px} | ||
| .notrun h4{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} | ||
| .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the unnecessary font-family quotes.
Stylelint reports font-family-name-quotes on Line 20. Use the unquoted identifier to satisfy the enabled rule.
Proposed fix
- .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)}
+ .notrun h3{font-family:Fraunces,serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .notrun h3{font-family:'Fraunces',serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} | |
| .notrun h3{font-family:Fraunces,serif;font-weight:300;font-size:21px;letter-spacing:-.018em;color:var(--sig)} |
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 20-20: Expected no quotes around "Fraunces" (font-family-name-quotes)
(font-family-name-quotes)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@public/specimen.css` at line 20, Update the .notrun h3 font-family
declaration to use the unquoted Fraunces identifier, removing only the
unnecessary quotes while preserving the existing fallback and other styling.
Source: Linters/SAST tools
|
Closing as a duplicate of #27. The two branches produce a byte-identical content diff (same 10 files, same 203/46 line counts); they differ only in blob hashes and hunk offsets because #27 was cut from a newer base. #27 also carries the Overseer verdict (Opus 5, midday shift 2026-08-09). Root cause is item selection, not the work: the loop re-picked the heading-hierarchy backlog item ~4h after already having an open PR for it. Logged for the dedupe fix. |
|
Correction to my previous comment: #22, #27 and #28 were all the same heading-hierarchy item. #28 is the one that landed (merged as |
…(PR #22 conflict-locked, superseded by #28) against current GitHub state (2026-08-12) (#152) Closes the review item "Two open PRs carry the same heading-hierarchy fix — PR #22 is conflict-locked and superseded" (review queue, unreviewed-by-grok), re-verified against the current GitHub state on 2026-08-12. Verified facts (2026-08-12): - PR #22 is CLOSED (2026-08-09), never merged, mergeStateStatus: DIRTY (conflict-locked) at close — the item's description was accurate. - The superseding fix PR #28 is MERGED on main (2026-08-09, commit 7be3d8f); sibling duplicate #27 is also CLOSED. - All 53 currently open PRs diff-reviewed: the only literal heading markup anywhere is one hierarchy-preserving h2 on /specimen in PR #107 (with its locked outline updated in scripts/test-heading-hierarchy.mjs) and one standalone h1 in PR #116's new closed-intake page — zero open PR retags an existing heading level, so no open PR duplicates the heading fix. - Main has carried exactly one heading fix since 2026-08-09: the only heading-tag change since the merge is 2ae7504's two hierarchy-preserving homepage FAQ h3s (PR #102, locked outline updated). npm run check passes and npm test passes in full (test:headings 6/6) on current origin/main (ad9cee3). - Site-side verification is current via docs/evidence/heading-hierarchy-2026-08-09.md (PR #74) with the 2026-08-12 re-verify in flight as PR #120. Docs-only change; no code, no deployment.
intended-outcome: Fix skipped heading levels on the home page (and the other three owned public pages) so the native document outline descends without gaps — h1 -> h2 -> h3 — while leaving the rendered appearance untouched.
The TinyStudio.io dogfood audit found the homepage (and agents, pricing, specimen) skipping heading levels: sections under h2 used h4 sub-headings, and the roster/specimen used h3 directly under the h1. This change retags the sub-headings one level shallower, retargets the affected CSS selectors (so nothing visually changes), and adds a deterministic regression test (
scripts/test-heading-hierarchy.mjs, wired intonpm test) that locks the corrected outline per page and proves the checker rejects the pre-fix shapes.verify: /home/nish/.local/bin/test-gate npm run check; /home/nish/.local/bin/test-gate npm test; git diff --check; sgscan
Repository proof only: heading hierarchy and tests, locally verified. No live deployment, ranking, or accessibility-certification claim is made. No deployment or merge in this change.
Summary by CodeRabbit
Bug Fixes
Tests