fix: write the 0x prefix back onto each hex string in an array - #1122
Merged
juanfranblanco merged 1 commit intoSep 26, 2026
Merged
Conversation
EnsureHexPrefix on a string array called the string helper and dropped the result, so the array came back unchanged.
Member
|
Thank you! |
Contributor
Author
|
Thanks for merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureHexPrefixon astring[]called the string helper and ignored the return value, so the array was handed back unchanged.new[] { "deadbeef", "0xabc" }stayeddeadbeefand0xabc.The loop now writes each prefixed string back. A value that already has
0xis left as it is. A null array still returns null.Someone who prefixes a batch of addresses or hashes before a call was getting the original strings. The method returned success and did not add the prefix.
Test plan
Assert.Equalon0xdeadbeef) and passes afterShouldEnsureHexPrefixNethereum.ABI.UnitTestssuite was not run here. That project pulls the rest of the solution. The focused test compilesHexByteConvertorExtensions.cson net8.0 and is 1 passedMade with Cursor