Conversation
crissman
force-pushed
the
container-prompt-names
branch
from
September 7, 2026 00:41
1fc2eb4 to
47f1c00
Compare
crissman
marked this pull request as draft
September 7, 2026 00:44
crissman
force-pushed
the
container-prompt-names
branch
5 times, most recently
from
September 7, 2026 01:37
d809f6e to
b753ca7
Compare
When looting, the item prompts only said "Put in what?", "Take out
what?" or "What do you want to stash?". With several containers in
inventory it is easy to load the wrong one -- including putting a bag
of holding into a bag of holding.
Name the container in those prompts, using its full description:
Put what type of objects into a blessed bag called holding
containing 27 items?
Take what out of an empty uncursed sack?
What do you want to stash in a blessed bag called holding
containing 27 items?
Built with safe_qbuf(doname, ansimpleoname), the same way pickup.c's
"Pick up <object>?" prompt is, so a long name falls back to the simple
form instead of overflowing. The "Do what with your <container>?"
action menu and the per-item askchain() prompts ("put in <item>?") are
unchanged.
crissman
force-pushed
the
container-prompt-names
branch
from
September 7, 2026 01:41
b753ca7 to
9b4fc3b
Compare
crissman
marked this pull request as ready for review
September 7, 2026 01:44
Author
|
Would you welcome naming the container in loot prompts? I’d appreciate feedback on the wording or implementation, or whether you prefer the current behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looting a container, the item prompts don't say which container:
With several containers in inventory it's easy to load the wrong one. I put a bag
of tricks into a bag of holding this way; the "Do what with your bag called
holding?" line scrolls off before the item selection appears.
This names the container in those prompts, using its full description (BUC state and
contents count included):
Implementation: the prompts in
menu_loot(),traditional_loot()(class prompt only —the per-item
askchain()prompts keep the short "put in" verb) andgetobj()(verb"stash") are built with
safe_qbuf(..., doname, ansimpleoname, ...), the same idiom asthe "Pick up ?" prompt in
pickup.c, so a long name falls back to the simple forminstead of overflowing. No new functions. The "Do what with your ?" action menu is unchanged. The existing "You cannot fit X into Y" messages are unchanged.
Tested in tty and Qt on macOS with menustyle full and traditional, against the
5.0.0 release; rebased onto current
NetHack-5.0and compile-checked there.🤖 Generated with Claude Code
🙎♂️ Reviewed by human Crissman
https://claude.ai/code/session_01WJwWF29Bgj7KvkVqPrVr5M