Conversation
plname_from_file() passed the relative gs.SAVEF to nh_uncompress() and nh_compress(), so freopen() resolves the path against the current working directory. That fails when the save directory (VAR_PLAYGROUND) differs from the directory NetHack chdir()s into at startup (HACKDIR), as in some packaged builds: starting with an existing save prints "freopen of save/<uid><name> for compress failed; (2) No such file or directory" and corrupts the display. Qualify the path with fqname(gs.SAVEF, SAVEPREFIX, 0), as the other save-file paths already do.
|
There's.a reason that fork+exec of compress does not use absolute paths. Unfortunately I don't remember what that reason is. Permission issues with the subprocess most likely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve #1628