Conversation
Contributor
Author
|
Rebased onto current |
Pass attachMetadata through to the rendered ServiceMonitor so Prometheus can expose node discovery metadata for relabeling. Document the Prometheus and RBAC prerequisites and cover the rendered chart contract. Signed-off-by: git-jxj <65210887+git-jxj@users.noreply.github.com>
git-jxj
force-pushed
the
git-jxj/add-servicemonitor-attach-metadata
branch
from
September 21, 2026 06:06
b5bf796 to
cefad3d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceMonitor.attachMetadatathrough to the renderedServiceMonitorThis allows the values already shown in #529 to expose Kubernetes node discovery metadata such as
__meta_kubernetes_node_label_*to relabeling rules.Fixes #529
Validation
go test ./tests/static -count=1helm lint deployment --set serviceMonitor.attachMetadata.node=truemake check-fmtmake lint LINT_BASE_REV=origin/main(0 issues)helm template ... --set serviceMonitor.attachMetadata.node=trueomitted the field before this change; the updated chart rendersspec.attachMetadata.node: true