Sitelet https://github.com/NHSDigital/NHSDigital-FHIR-Genomics-ImplementationGuide/pull/258
Skip to content

Fixes to StructureDefinitions - #258

Open
omarisgreat wants to merge 4 commits into
mainfrom
patch-AWS-Package-fixes
Open

Fixes to StructureDefinitions#258
omarisgreat wants to merge 4 commits into
mainfrom
patch-AWS-Package-fixes

Conversation

@omarisgreat

Copy link
Copy Markdown
Contributor

Largely adding discriminators

Largely adding discriminators
@omarisgreat

Copy link
Copy Markdown
Contributor Author

Hi @KazeemHamzat, would you be able to review, and also merge in your validator fixes to preempt any further issues raised by AWS?

@KazeemHamzat

Copy link
Copy Markdown
Collaborator

Hi @KazeemHamzat, would you be able to review, and also merge in your validator fixes to preempt any further issues raised by AWS?

I used JPA to validate this branch but generated some errors. Details here

Updated StructureDefinitions and specific errors in examples
@omarisgreat

Copy link
Copy Markdown
Contributor Author

@KazeemHamzat, I've made some further updates, would you mind retesting with JPA?

@KazeemHamzat

KazeemHamzat commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

@KazeemHamzat, I've made some further updates, would you mind retesting with JPA?

It is now passing validation but needs these two changes that I have added.
Issue 1
Removing Slicing from DiagnosticReport.category. It Should be inherited from the base. e.g,
"id": "DiagnosticReport.category",
"path": "DiagnosticReport.category",
"slicing": {
"discriminator": [
{
"type": "value",
"path": "coding"
}
],
Issue 2
This relates to non-compatible target profiles with Base.

Remove Slicing from DiagnosticReport.category

@KazeemHamzat KazeemHamzat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants