feat: Add option to ignore built-in display in combined slider mode - #1879
Open
jonaaix wants to merge 1 commit into
Open
feat: Add option to ignore built-in display in combined slider mode#1879jonaaix wants to merge 1 commit into
jonaaix wants to merge 1 commit into
Conversation
When 'Use combined slider for all displays' is enabled, a new 'Ignore built-in display' checkbox appears in the App menu settings. When checked, the built-in (MacBook) display is excluded from the combined menu slider and from 'all screens' keyboard brightness control, since its much higher peak brightness otherwise stands out next to external displays.
Member
|
Thank you for putting this together and for the clear description and localizations! This is a thoughtful and well-executed contribution. My concern is that the new App menu option also changes the behavior of the separate Keyboard setting: “All screens” would no longer actually control all screens. Changing the App menu slider mode would therefore silently change keyboard behavior as well, which could be confusing. Because of this coupling, I won’t merge the PR, but the contribution is still valuable. I’ll leave it open as a fork recommendation for anyone specifically looking for a MonitorControl version with this behavior. Thanks again for the work and effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to ignore built-in display in combined slider mode
Summary
When "Use combined slider for all displays" is enabled, the combined slider also controls the built-in MacBook display. Since the built-in display gets significantly brighter than typical external monitors at the same relative setting, it always stands out — making the combined slider practically unusable in everyday use.
This PR adds a new "Ignore built-in display" checkbox, shown only when combined slider mode is selected. When enabled, the built-in display is excluded from combined control.
What changed
getAffectedDisplays, so both paths are covered with a single change)Implementation notes
combineExcludeBuiltin(defaults to off — no behavior change for existing users)DisplayManager.isBuiltinExcludedFromCombinedSlider()and used by bothMenuHandlerandDisplayManager.getAffectedDisplays()Screenshots
How to test