Fix NoSlow and FastClimb leaving timer overrides active - #6688
Open
c8dhjp4tyv-bit wants to merge 1 commit into
Open
c8dhjp4tyv-bit wants to merge 1 commit into
c8dhjp4tyv-bit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disabling NoSlow while falling through a cobweb, or FastClimb while climbing, leaves the Timer override active. Changing the timer mode has the same problem.
Track whether each module has applied an override and release it on deactivation, when leaving the relevant block, or when switching modes. An idle module no longer clears the timer on its first tick.
Related to the timer cleanup report in #6544 by @sebastiaana8620-a11y.
Validation
16 standalone Java 25 regression cases passed using the actual NoSlow, FastClimb and Timer classes with minimal Minecraft/settings test doubles. The original code failed 10 of these cases.
Full Gradle build was blocked by unavailable dependencies. No in-game testing was performed. Prepared with AI assistance.