Sitelet https://github.com/KnpLabs/KnpMenu/pull/397
Skip to content

add Twig Runtime - #397

Merged
garak merged 2 commits into
KnpLabs:masterfrom
garak:fix-twig-ext
Dec 11, 2024
Merged

garak merged 2 commits into
KnpLabs:masterfrom
garak:fix-twig-ext

Conversation

@garak

@garak garak commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

Fix #396 in a BC way

@garak

garak commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator Author

Test failures are unrelated and due to the spaceless filter deprecation.
I opened a specific issue about it #398

@garak
garak requested review from alexpozzi and stof September 5, 2024 17:23

@alexpozzi alexpozzi left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Are you gonna fix tests in this PR or in a following one?

@garak

garak commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

Nice, thanks!

Are you gonna fix tests in this PR or in a following one?

I've tried to fix the tests, but it seems that allowing one deprecation is not enough.
I proposed another PR about removing the use of the spaceless tag, it's still under review

@garak
garak merged commit 9747837 into KnpLabs:master Dec 11, 2024
@garak
garak deleted the fix-twig-ext branch December 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimise Twig extension

2 participants