Add a CI job running phpstan - #367
Merged
Merged
Conversation
derrabus
reviewed
Jan 18, 2022
| "symfony/routing": "^4.4 || ^5.0 || ^6.0", | ||
| "twig/twig": "^1.40 || ^2.9 || ^3.0" | ||
| "twig/twig": "^1.40 || ^2.9 || ^3.0", | ||
| "phpstan/phpstan": "^1.4" |
Contributor
There was a problem hiding this comment.
So far, the dependencies were sorted alphabetically. You're about to change that. 🙃
Collaborator
Author
There was a problem hiding this comment.
yeah, they were sorted, but without the config telling composer require to apply the sorting. Let me change that.
stof
commented
Jan 18, 2022
| path: src/Knp/Menu/Matcher/Voter/RouteVoter.php | ||
|
|
||
| - | ||
| message: "#^Strict comparison using \\=\\=\\= between false and array\\<Knp\\\\Menu\\\\ItemInterface\\> will always evaluate to false\\.$#" |
Collaborator
Author
There was a problem hiding this comment.
this one is because array_combine returns false only on PHP 7, not on PHP 8 (on PHP 8, it throws an exception on failure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phpstan configuration was there, but not running on CI, which made it be forgotten.