Conversation
Collaborator
|
Hmm, yeah this was sort of what I had before I changed it to accommodate |
Contributor
|
@xiphirx how are things going on your end. You think you have a chance to follow up on this? Would be great. |
Contributor
|
@zawadz88 thank you for submitting this PR and bringing its status to Engin attention at DriodCon in Berlin. |
Collaborator
|
Fixed in #300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a fix for #91.
Before the changes the following was happening:
These changes work for me in the sample app and in the app I'm working on, however I changed the part below the
FLAG_LAYOUT_NO_LIMITScomment which I couldn't find how to reproduce so I'm not sure if this will work in this scenario.