Fix builds on forked pull requests - #187
Conversation
The action `dorny/test-reporter@v1` requires write permissions, which are not available for pull requests from forked repositories.
|
FYI, I would also suggest to set |
b8ffd16 to
a055f88
Compare
|
I removed the workaround (b8ffd16) from this pull request since dorny/test-reporter#438 and dorny/test-reporter#444 are resolved. PS: Due to these fixes, the reports should also start to work again for the gradle-changelog-plugin. Test Report 105 at https://github.com/JetBrains/gradle-changelog-plugin/actions/workflows/test-report.yml seems to be the last failed run, future runs should work again. You may also try to re-run one of them to test it. |
|
Thanks a lot for this PR and the research, sorry for delay in handling. |
Pull Request Details
Description
The action
dorny/test-reporter@v1requires write permissions, which are not available for pull requests from forked repositories.This PR applies the same fix as in JetBrains/gradle-changelog-plugin#170. Due to dorny/test-reporter#343, this fix alone didn't work, so I also applied a workaround with commit b8ffd16.
Note that I also just created a pull request at dorny/test-reporter#436 which fixes the second issue according to my tests. Depending on whether and how fast the PR gets accepted, the workaround might become obsolete soon.
Related Issue
Motivation and Context
Fix the build of #179.
How Has This Been Tested
I created a pull request on my fork with a failing unit test.
JojOatXGME#1
This demonstrates that the test reports are still working. However, this test does not demonstrate that the bug is actually fixed, since my pull request is not coming from a different fork. However, it worked for the gradle-changelog-plugin.
Types of changes
Checklist