[repo-assist] improve site mapping argument validation - #1435
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
The site-mapping extension methods now validate their collection argument explicitly instead of failing later with an unhelpful
NullReferenceException. Regression tests cover both public extension methods.Rationale
Explicit
ArgumentNullExceptionguards make the API contract clear and provide an actionable failure for invalid callers without changing valid-call behavior.Test Status
dotnet build EssentialCSharp.Web.Tests/EssentialCSharp.Web.Tests.csproj --configuration Release --no-restoregit diff --checkdotnet test EssentialCSharp.Web.Tests/EssentialCSharp.Web.Tests.csproj --configuration Release --no-build: 151/153 passed;CaptchaService_Verify_SuccessandKnownBreachedPassword_IsDetectedfailed because their external services were unavailable.dotnet format ... --verify-no-changesreports pre-existing formatting findings in unrelated files; no formatting changes were made outside this patch.No new dependencies were added.
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
api.hcaptcha.comapi.pwnedpasswords.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run