Repository navigation
Add Cloud Tasks snippets - #1537
Merged
Merged
Conversation
kurtisvg
suggested changes
Aug 6, 2019
| @@ -0,0 +1,314 @@ | |||
| /* | |||
| * Copyright 2018 Google LLC | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2018 Google LLC | |
| * Copyright 2019 Google LLC |
| // [END taskqueues_retrying_tasks] | ||
|
|
||
| // Run sample: mvn clean package exec:java -Dexec.mainClass="com.example.appengine.Snippets" | ||
| public static void main(String[] args) throws Exception { |
| import java.nio.charset.Charset; | ||
|
|
||
| public class Snippets { | ||
| // [START taskqueues_using_yaml] |
Contributor
There was a problem hiding this comment.
Should these follow the new format and be in different files?
kurtisvg
approved these changes
Aug 6, 2019
kurtisvg
left a comment
Contributor
There was a problem hiding this comment.
You have a few region tags that don't follow the guidelines from the previous sample - if they aren't in use it would be nice to remove them (or update if they are still being used).
| queue.add(TaskOptions.Builder.withurl(/sitelet?url=https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fjava-docs-samples%2Fpull%2F%26quot%3B%2Fworker%26quot%3B).param("key", key)); | ||
| // [END addQueue] | ||
| try (CloudTasksClient client = CloudTasksClient.create()) { | ||
| String projectId = "starter-akitsch"; |
Contributor
Author
There was a problem hiding this comment.
?! I have no idea how that file got added to this PR?!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.